Project

General

Profile

Bug #7496

cmp_ds_cont has never worked

Added by Prakash Surya about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
zfs - Zettabyte File System
Start date:
2016-10-24
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage

Description

The "cmp_ds_cont" function in the zfs-test suite ends with a call to "echo". As a result, any consumers of this function interpreting its return code to mean "success" or "failure" would have been flawed (i.e. if it was used in conjunction with "log_must"), as the return code of the function would have been the return code of the "echo" command; i.e. it would almost always report success.

History

#1

Updated by Electric Monk about 3 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit 5dc1fd74a412d1fb1af3c2b8b3df3473b7588e14

commit  5dc1fd74a412d1fb1af3c2b8b3df3473b7588e14
Author: John Wren Kennedy <john.kennedy@delphix.com>
Date:   2016-11-07T06:23:54.000Z

    7496 cmp_ds_cont has never worked
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Paul Dagnelie <pcd@delphix.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Also available in: Atom PDF