Project

General

Profile

Bug #7502

ztest should run zdb with -G (debug mode)

Added by Prakash Surya almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
zfs - Zettabyte File System
Start date:
2016-10-24
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

Right now ztest executes zdb without -G, so when it has errors, the messages are often not very helpful:

Executing zdb -bccsv -d -U /rpool/tmp/zpool.cache ztest
zdb: can't open 'ztest': Operation not supported
ztest: '/usr/sbin/amd64/zdb -bccsv -d -U /rpool/tmp/zpool.cache ztest' exit code 1

With -G, we'd have:

/usr/sbin/amd64/zdb -bccsv -d -U /rpool/tmp/zpool.cache -G ztest
zdb: can't open 'ztest': Operation not supported

ZFS_DBGMSG(zdb):
spa_open_common: opening ztest
spa_load(ztest): LOADING
spa_load(ztest): FAILED: unable to parse config [error=48]
spa_load(ztest): UNLOADING

Which indicates where the error came from

History

#1

Updated by Electric Monk almost 3 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit c3c65d17f7b6689bbd6568a1a1fcc0c4a3bac127

commit  c3c65d17f7b6689bbd6568a1a1fcc0c4a3bac127
Author: Pavel Zakharov <pavel.zakharov@delphix.com>
Date:   2016-11-07T06:26:12.000Z

    7502 ztest should run zdb with -G (debug mode)
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Dan Kimmel <dan.kimmel@delphix.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Also available in: Atom PDF