Project

General

Profile

Actions
Copy link

Bug #7540

closed

loader zfs should check all labels

Added by Toomas Soome about 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
bootloader
Start date:
2016-11-07
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
External Bug:

Description

The current loader code does read pool data only from first label on disk. While in general it should be enough, still there is an chance we will hit disk issue or missing updates on label.

The first take on issue is https://www.illumos.org/rb/r/250/

For test and verification, I had debug printouts to verify the txg numbers on all 4 label instances, also for UB scan - those printfs are removed from patch posted in reviewboard.

Note there is also parallel work at fbsd side, and using slightly different approach: https://reviews.freebsd.org/D8464.

Actions
Copy link
 #1

Updated by Electric Monk over 6 years ago

  • Status changed from New to Closed
  • % Done changed from 80 to 100

git commit edb35047b6b720980b6de7117a950b94ae288202

commit  edb35047b6b720980b6de7117a950b94ae288202
Author: Toomas Soome <tsoome@me.com>
Date:   2017-04-05T04:23:47.000Z

    7540 loader zfs should check all labels
    Reviewed by: Andriy Gapon <agapon@gmail.com>
    Reviewed by: Paul Dagnelie <pcd@delphix.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Actions
Copy link

Also available in: Atom PDF