vmxnet3s MAC callbacks erroneously return DDI_ return values
Device callbacks for the MAC module are expected to return 0 for success, and a positive non-zero error code (errno) on failure. The vmxnet3s driver's MAC callbacks currently only return DDI_SUCCESS or DDI_FAILURE. The fact that DDI_SUCCESS is 0 is a happy and harmless coincidence, but the lack of error codes could be problematic for diagnostic purposes.
Updated by Electric Monk over 5 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100
commit 6849994e8263545ed3c0f6f5676e47b38e14f63e Author: Sebastien Roy <firstname.lastname@example.org> Date: 2016-11-18T00:22:11.000Z 7582 vmxnet3s MAC callbacks erroneously return DDI_ return values 7583 vmxnet3s rx buffer allocations can result in system unresponsiveness Reviewed by: Pavel Zakharov <email@example.com> Reviewed by: Matthew Ahrens <firstname.lastname@example.org> Reviewed by: Steve Gonczi <email@example.com> Reviewed by: Robert Mustacchi <firstname.lastname@example.org> Reviewed by: Dan McDonald <email@example.com> Approved by: Richard Lowe <firstname.lastname@example.org>