Project

General

Profile

Bug #7582

vmxnet3s MAC callbacks erroneously return DDI_ return values

Added by Daniel Kimmel almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2016-11-14
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

Device callbacks for the MAC module are expected to return 0 for success, and a positive non-zero error code (errno) on failure. The vmxnet3s driver's MAC callbacks currently only return DDI_SUCCESS or DDI_FAILURE. The fact that DDI_SUCCESS is 0 is a happy and harmless coincidence, but the lack of error codes could be problematic for diagnostic purposes.

History

#1

Updated by Electric Monk almost 3 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit 6849994e8263545ed3c0f6f5676e47b38e14f63e

commit  6849994e8263545ed3c0f6f5676e47b38e14f63e
Author: Sebastien Roy <seb@delphix.com>
Date:   2016-11-18T00:22:11.000Z

    7582 vmxnet3s MAC callbacks erroneously return DDI_ return values
    7583 vmxnet3s rx buffer allocations can result in system unresponsiveness
    Reviewed by: Pavel Zakharov <pavel.zakharov@delphix.com>
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Steve Gonczi <steve.gonczi@delphix.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Dan McDonald <danmcd@omniti.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF