Actions
Bug #7582
closedvmxnet3s MAC callbacks erroneously return DDI_ return values
Start date:
2016-11-14
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
Description
Device callbacks for the MAC module are expected to return 0 for success, and a positive non-zero error code (errno) on failure. The vmxnet3s driver's MAC callbacks currently only return DDI_SUCCESS or DDI_FAILURE. The fact that DDI_SUCCESS is 0 is a happy and harmless coincidence, but the lack of error codes could be problematic for diagnostic purposes.
Updated by Electric Monk over 5 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100
git commit 6849994e8263545ed3c0f6f5676e47b38e14f63e
commit 6849994e8263545ed3c0f6f5676e47b38e14f63e Author: Sebastien Roy <seb@delphix.com> Date: 2016-11-18T00:22:11.000Z 7582 vmxnet3s MAC callbacks erroneously return DDI_ return values 7583 vmxnet3s rx buffer allocations can result in system unresponsiveness Reviewed by: Pavel Zakharov <pavel.zakharov@delphix.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: Steve Gonczi <steve.gonczi@delphix.com> Reviewed by: Robert Mustacchi <rm@joyent.com> Reviewed by: Dan McDonald <danmcd@omniti.com> Approved by: Richard Lowe <richlowe@richlowe.net>
Actions