Project

General

Profile

Bug #7586

remove #ifdef __lint hack from dmu.h

Added by Daniel Kimmel about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
zfs - Zettabyte File System
Start date:
2016-11-15
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

The #ifdef __lint in dmu.h is ugly, and it would be nice not to duplicate it if we add other inline functions into header files in ZFS, especially since it is difficult to make any other solution work across all compilation targets. We should switch to disabling the lint flags that are failing instead.

History

#1

Updated by Dan McDonald about 3 years ago

For those concerned about apps losing correctness checks, this comes from the OpenZFS PR: https://github.com/openzfs/openzfs/pull/255

gcc will detect unused statics correctly but not get tripped up by inline functions. So it's true that lint won't notice, but as long a we aren't gagging unused functions, it should be fine.

#2

Updated by Electric Monk about 3 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 4ba5b9616327ef64e8abc737d29b3faabc6ae68c

commit  4ba5b9616327ef64e8abc737d29b3faabc6ae68c
Author: Dan Kimmel <dan.kimmel@delphix.com>
Date:   2016-12-02T20:32:27.000Z

    7586 remove #ifdef __lint hack from dmu.h
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Pavel Zakharov <pavel.zakharov@delphix.com>
    Approved by: Dan McDonald <danmcd@omniti.com>

Also available in: Atom PDF