Project

General

Profile

Actions

Bug #7638

closed

Refactor spa_load_impl into several functions

Added by Pavel Zakharov over 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Category:
zfs - Zettabyte File System
Start date:
2016-12-02
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

spa_load_impl has grown out of proportions.
It is currently over 700 lines long and makes it very hard to follow or debug the import process even for experienced ZFS developers.
The objective is to split it up in a series of well commented functions.

A PR is ready on openzfs.

Actions #1

Updated by Electric Monk over 4 years ago

  • Status changed from New to Closed

git commit 1fd3785ff6601d3e391378c2dcbf4c5f27e1fe32

commit  1fd3785ff6601d3e391378c2dcbf4c5f27e1fe32
Author: Pavel Zakharov <pavel.zakharov@delphix.com>
Date:   2018-02-06T17:36:44.000Z

    7638 Refactor spa_load_impl into several functions
    Reviewed by: Paul Dagnelie <pcd@delphix.com>
    Reviewed by: George Wilson <george.wilson@delphix.com>
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF