Project

General

Profile

Actions

Bug #7691

closed

uts: fakebop should not output unprintable data

Added by Toomas Soome almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
kernel
Start date:
2016-12-26
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

When prom_debug and/or kbm_debug is set, the early boot will produce debug output of set and discovered properties. The current code does interpret all properties as strings, which is not always true. Outputting binary data directly to terminal will interfere with terminal and can render terminal into bad state - such as activating alternate character sets and so on. So we have to make sure we do not output non-printable data to the terminal.

Actions #1

Updated by Electric Monk almost 5 years ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit 01ed526b57e7c0160dae523eb408e5f8a3240fcb

commit  01ed526b57e7c0160dae523eb408e5f8a3240fcb
Author: Toomas Soome <tsoome@me.com>
Date:   2017-01-05T12:29:20.000Z

    7691 uts: fakebop should not output unprintable data
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Yuri Pankov <yuri.pankov@gmail.com>
    Approved by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>

Actions

Also available in: Atom PDF