Project

General

Profile

Actions

Bug #7702

closed

kstat(1) doesn't deal well with uninitialized named kstats

Added by Robert Mustacchi over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Category:
cmd - userland programs
Start date:
2016-12-29
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

As it turns out, drivers can fail to initialize some named kstats (and apparently, some do – see https://smartos.org/bugview/OS-5723). kstat (1) currently deals very poorly with this condition, dumping random memory for those members. It obviously needs to be more resilient to these kstats.

Actions #1

Updated by Electric Monk over 5 years ago

  • Status changed from New to Closed

git commit 774814910cba5b65219849ca27b13b2fbe8127ee

commit  774814910cba5b65219849ca27b13b2fbe8127ee
Author: Bryan Cantrill <bryan@joyent.com>
Date:   2016-12-30T14:59:04.000Z

    7701 kstat -j does not produce valid JSON
    7702 kstat(1) doesn't deal well with uninitialized named kstats
    7703 in some locales, kstat -j produces invalid JSON
    Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions

Also available in: Atom PDF