Bug #7715
closed
loader binaries causes wsdiff false positives
100%
Description
When the illumos-gate is built twice in a row the gptzfsboot, pxeboot, and zfsloader binaries differs, so wsdiff(1onbld) reports them.
The differences are these:
boot/gptzfsboot NOTE: ASCII difference detected. 13628,13629c13628,13629 < 0325060 \0 \0 \0 \0 \0 \0 \0 \0 ` \0 \0 \0 001 243 r [ < 00000000 00000000 00000060 5b72a301 --- > 0325060 \0 \0 \0 \0 \0 \0 \0 \0 ` \0 \0 \0 005 241 u ] > 00000000 00000000 00000060 5d75a105 13640,13641c13640,13641 < 0325220 2 3 1 T 1 1 3 2 4 6 Z \0 \0 \0 \0 \0 < 54313332 32333131 005a3634 00000000 --- > 0325220 2 3 1 T 1 4 0 0 0 5 Z \0 \0 \0 \0 \0 > 54313332 30303431 005a3530 00000000 boot/pxeboot NOTE: ASCII difference detected. 33460,33461c33460,33461 < 1044700 D e c 3 1 1 2 : 3 2 : 4 1 < 63654420 20313320 333a3231 31343a32 --- > 1044700 D e c 3 1 1 5 : 0 0 : 0 0 > 63654420 20313320 303a3531 30303a30 boot/zfsloader NOTE: ASCII difference detected. 33396,33397c33396,33397 < 1043700 D e c 3 1 1 2 : 3 2 : 4 1 < 63654420 20313320 333a3231 31343a32 --- > 1043700 D e c 3 1 1 5 : 0 0 : 0 0 > 63654420 20313320 303a3531 30303a30
Updated by Marcel Telka almost 5 years ago
The vers.c file is updated with the current timestamp on every build by usr/src/boot/sys/boot/common/newvers.sh.
Updated by Toomas Soome almost 5 years ago
- Assignee set to Toomas Soome
I was thinking when someone will step on this issue. For loaders its about changes:
https://reviews.freebsd.org/D8823
https://reviews.freebsd.org/D8842
for boot1 we need a bit different solution. The problem there is that it is nice to have way to identify boot1 binary, for this purpose, we have installboot -i, and so the easy path was just to embed the build date, which will break repeatable build. Better way is to embed the version info without date, so we get repeatable build within same version. So, I'll add subtask for boot1 versioning.
Updated by Electric Monk over 4 years ago
- Status changed from New to Closed
git commit f6c9444388aee97beabfda543e0845ab11c9d7b1
commit f6c9444388aee97beabfda543e0845ab11c9d7b1
Author: Toomas Soome <tsoome@me.com>
Date: 2017-03-10T18:07:16.000Z
7715 loader binaries causes wsdiff false positives
Reviewed by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>
Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>
Approved by: Robert Mustacchi <rm@joyent.com>