Project

General

Profile

Actions

Bug #7795

closed

loader: gcc6 build warnings

Added by Toomas Soome over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
2017-01-21
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

zfsboot.c:92:26: warning: 'dev_nm' defined but not used [-Wunused-const-variable=]
static const char *const dev_nm[NDEV] = {"ad", "da", "fd"};

and somehow I have managed to have ; at the end of the if statement:

../zfs.c: In function 'zfs_bootfs':
../zfs.c:693:4: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if (kid->v_state VDEV_STATE_HEALTHY &&
^
../zfs.c:695:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
break;
^
~~~
../zfs.c:701:3: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if (vdev->v_state VDEV_STATE_HEALTHY &&
^
../zfs.c:703:4: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
break;
^
~~~

Actions #1

Updated by Electric Monk over 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 6a81003a6cb2a9fe9b6a4acbc0c1a6ec5c0ebbec

commit  6a81003a6cb2a9fe9b6a4acbc0c1a6ec5c0ebbec
Author: Toomas Soome <tsoome@me.com>
Date:   2017-01-23T19:00:44.000Z

    7795 loader: gcc6 build warnings
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Reviewed by: Alexander Pyhalov <apyhalov@gmail.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Actions

Also available in: Atom PDF