Project

General

Profile

Bug #7811

dont send obsolete mode pages to SSDs, SATA, SBC2 and later conforming devices

Added by Yuri Pankov about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2017-01-27
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:

Description

$ iostat -En
c1t0d0           Soft Errors: 0 Hard Errors: 0 Transport Errors: 0
Vendor: ATA      Product: OCZ-AGILITY4     Revision: 1.3  Serial No: OCZ-DC1N3LO88DR
Size: 64.02GB <64023257088 bytes>
Media Error: 0 Device Not Ready: 0 No Device: 0 Recoverable: 0
Illegal Request: 4 Predictive Failure Analysis: 0
c1t1d0           Soft Errors: 0 Hard Errors: 0 Transport Errors: 0
Vendor: ATA      Product: WDC WD10EZEX-21W Revision: 1A01 Serial No: WCC6Y0SPLHE7
Size: 1000.20GB <1000204886016 bytes>
Media Error: 0 Device Not Ready: 0 No Device: 0 Recoverable: 0
Illegal Request: 2 Predictive Failure Analysis: 0

We do not support MODE SENSE mode page 0x03 (which is what the reported problem-CDB represents) for SATA disks attached through a SATA hba.
In fact our code has a specific comment about this "Page 3 and 4 are obsolete and we are not supporting them." (http://src.illumos.org/source/xref/illumos-gate/usr/src/uts/common/io/sata/impl/sata.c#5116)

Proposed fix is to modify sd driver's sd_get_physical_geometry() function so that it will return before sending the MODE SENSE (6) mode pages 0x03 and 0x04 CDBs to the disk.


Related issues

Related to illumos gate - Bug #2087: sd needs to detect and handle SBC-3 correctlyFeedback2012-02-08

Actions

History

#1

Updated by Electric Monk about 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 50 to 100

git commit 1b4eec21f9cfdfd599c5aacb90149329734c4f81

commit  1b4eec21f9cfdfd599c5aacb90149329734c4f81
Author: Alek Pinchuk <alek@nexenta.com>
Date:   2017-02-27T13:36:43.000Z

    7811 dont send obsolete mode pages to SSDs, SATA, SBC2 and later conforming devices
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
    Approved by: Dan McDonald <danmcd@omniti.com>

#2

Updated by Yuri Pankov about 3 years ago

  • Related to Bug #2087: sd needs to detect and handle SBC-3 correctly added

Also available in: Atom PDF