get_clones_stat() is suboptimal for lots of clones
get_clones_stat() could be very slow if a snapshot has many (thousands) clones.
Clone names are added to an nvlist that's created with
So, each time a new name is appended to the list, the whole list is searched
linearly to see if that name is not already in the list. That results in the
That should be easy to fix as we know in advance that we should not get any
duplicate names, so we can drop
NV_UNIQUE_NAME when creating the list.
Updated by Electric Monk over 2 years ago
- % Done changed from 0 to 100
- Status changed from New to Closed
commit c5bde7273ef861a8dc54cfb9abe48d56062177da Author: Andriy Gapon <avg@FreeBSD.org> Date: 2017-03-01T05:12:23.000Z 7843 get_clones_stat() is suboptimal for lots of clones Reviewed by: Pavel Zakharov <firstname.lastname@example.org> Reviewed by: Matthew Ahrens <email@example.com> Approved by: Dan McDonald <firstname.lastname@example.org>