Tautological tests in XVA_SET_REQ and friends
XVA_SET_REQ contains an assertion that (xvap)->xva_vattr.va_mask | AT_XVATTR), where AT_XVATTR is a constant. This assertion is always true. The same expression appears in XVA_CLR_REQ, XVA_SET_RTN, XVA_ISSET_REQ, and XVA_ISSET_RTN. Was it supposed to use "&" instead of "|"? According to git blame, it was introduced in a gigantic code bomb that changed nearly 200,000 SLOC, so it's impossible to divine the programmer's intention.
Reported by: Coverity