Actions
Bug #7874
open
Tautological tests in XVA_SET_REQ and friends
Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2017-02-15
Due date:
% Done:
0%
Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
External Bug:
Description
XVA_SET_REQ contains an assertion that (xvap)->xva_vattr.va_mask | AT_XVATTR), where AT_XVATTR is a constant. This assertion is always true. The same expression appears in XVA_CLR_REQ, XVA_SET_RTN, XVA_ISSET_REQ, and XVA_ISSET_RTN. Was it supposed to use "&" instead of "|"? According to git blame, it was introduced in a gigantic code bomb that changed nearly 200,000 SLOC, so it's impossible to divine the programmer's intention.
https://github.com/openzfs/openzfs/commit/da6c28aaf62fa55f0fdb8004aa40f88f23bf53f0
Reported by: Coverity
Updated by Bryan Horstmann-Allen almost 5 years ago
- Project changed from site to illumos gate
Actions