Project

General

Profile

Actions
Copy link

Bug #7877

closed

libadm: the if condition is wrong in devreserv.c

Added by Toomas Soome over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
lib - userland libraries
Start date:
2017-02-15
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

../common/devreserv.c:475:45: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
       if (!write(lkfilefd, locklist, tblsz) == (ssize_t)tblsz)
                                             ^~
Actions
Copy link
 #1

Updated by Electric Monk over 6 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 2ed5314abaaa33c8ed0962cdac20e5a2b61de46b

commit  2ed5314abaaa33c8ed0962cdac20e5a2b61de46b
Author: Toomas Soome <tsoome@me.com>
Date:   2017-03-21T18:54:17.000Z

    7877 libadm: the if condition is wrong in devreserv.c
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Reviewed by: Yuri Pankov <yuri.pankov@gmail.com>
    Approved by: Dan McDonald <danmcd@omniti.com>

Actions
Copy link

Also available in: Atom PDF