Project

General

Profile

Bug #7887

get_zfs_dataset() optimised path leaks zfs handle

Added by Andrew Stormont almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Category:
lib - userland libraries
Start date:
2017-02-17
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

7857 introduced an additional logic which attempts to guess the dataset name for a share path. This logic does some fudging of the path and then calls zfs_open() on the result. It does not call zfs_close() if this is successful.


Related issues

Related to illumos gate - Bug #7741: get_zfs_dataset() takes an unreasonable amount of timeClosedPrakash Surya2017-01-06

Actions
#1

Updated by Andrew Stormont almost 4 years ago

  • Related to Bug #7741: get_zfs_dataset() takes an unreasonable amount of time added
#2

Updated by Electric Monk almost 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit ff524b2355c0ac08bf963297ae8e5ea2e8375852

commit  ff524b2355c0ac08bf963297ae8e5ea2e8375852
Author: Andrew Stormont <astormont@racktopsystems.com>
Date:   2017-02-19T17:56:04.000Z

    7857 zfs/zpool commands print scary errors after 7741
    7887 get_zfs_dataset() optimised path leaks zfs handle
    Reviewed by: Sam Zaydel <szaydel@racktopsystems.com>
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF