Project

General

Profile

Actions
Copy link

Bug #7894

closed

loader: Stop closing the network device when netbooting for loaders using the common dev_net.c code

Added by Toomas Soome over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
bootloader
Start date:
2017-02-19
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

FreeBSD change: https://svnweb.freebsd.org/base?view=revision&revision=r307238

The NETIF_OPEN_CLOSE_ONCE flag was added in r201932 to prevent that behavior on some architectures (sparc64 and powerpc64) the default was left to always open and close the device for each open and close of a file by the loader because it was necessary for u-boot on arm.

Since it has been added, the flag was turned on for every arches including the u-boot loader for arm.

This also fixes netbooting on RPi3 (tested by gonzo@)

For the loader.efi it greatly speeds up netbooting

Actions
Copy link
 #1

Updated by Electric Monk over 6 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 20d4f984477a2a115e362365dc6f201b59a14d27

commit  20d4f984477a2a115e362365dc6f201b59a14d27
Author: Toomas Soome <tsoome@me.com>
Date:   2017-03-02T13:55:52.000Z

    7894 loader: Stop closing the network device when netbooting for loaders using the common dev_net.c code
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>

Actions
Copy link

Also available in: Atom PDF