Project

General

Profile

Bug #7900

zdb shouldn't print the path of a znode at verbosity < 5

Added by Alan Somers over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
zfs - Zettabyte File System
Start date:
2017-02-21
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage

Description

zdb shouldn't print the path of a znode at verbosity < 5. There are two reasons:

1) Finding a znode's path is slower than printing any other znode information at verbosity < 5.
2) On a corrupted pool like the one mentioned below, zdb will crash when it tries to determine the znode's path. But with this patch, zdb can still extract useful information from such pools.

https://github.com/zfsonlinux/zfs/issues/5346

History

#1

Updated by Electric Monk over 2 years ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Closed

git commit e548d2fa41d1baa06662ed9abbb8bcec86e27dd9

commit  e548d2fa41d1baa06662ed9abbb8bcec86e27dd9
Author: Alan Somers <asomers@gmail.com>
Date:   2017-04-14T03:44:20.000Z

    7900 zdb shouldn't print the path of a znode at verbosity < 5
    Reviewed by: Paul Dagnelie <pcd@delphix.com>
    Reviewed by: Matt Ahrens <mahrens@delphix.com>
    Approved by: Dan McDonald <danmcd@omniti.com>

Also available in: Atom PDF