Project

General

Profile

Actions
Copy link

Bug #7920

closed

usba_hcdi_register() should fail if driver is using private data

Added by Robert Mustacchi over 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Robert Mustacchi
Category:
driver - device drivers
Start date:
2017-03-01
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

The usba_hcdi_register() routine is used to register a driver with USBA as a host controller. USBA expects that it can use the ddi_set_driver_private() function for this. This means that calling drivers that use it basically will never work. Rather than silently clobbering this, we should instead fail the registration immediately.

Actions
Copy link
 #1

Updated by Electric Monk about 6 years ago

  • Status changed from New to Closed

git commit 993e3faf6a142ae3efdd24388883264c2b56bede

commit  993e3faf6a142ae3efdd24388883264c2b56bede
Author: Robert Mustacchi <rm@joyent.com>
Date:   2017-03-10T18:21:18.000Z

    1979 USB 3.0 support
    7918 want usb_pipe_xopen(9F)
    7919 usbai burst macros for endpoint descriptor are wrong
    7920 usba_hcdi_register() should fail if driver is using private data
    7921 failing to load the usba root hub module destroys driver parent private data
    7922 want ::hubd walker
    7923 ::prtusb should include version
    7924 usb_*_request(9S) manual pages should match structure names
    Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Reviewed by: Bryan Cantrill <bryan@joyent.com>
    Reviewed by: Dale Ghent <daleg@omniti.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions
Copy link

Also available in: Atom PDF