Project

General

Profile

Bug #8010

loader: want mechanism to avoid RA with bcache

Added by Toomas Soome over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
2017-03-29
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

While we have mechanisms in place to protect ourselves against the read behind the disk end, there is still one corner case. As the GPT partition table has backup table at the end of the disk, and we yet do not know the size of the disk (if the wrong size is provided by the firmware/bios), we need to limit the reads to avoid read ahead in such case.

Discovered the problem with testing 32-bit UEFI and noticed the read failure messages.

History

#1

Updated by Toomas Soome over 3 years ago

The parallel review is up for FreeBSD: https://reviews.freebsd.org/D10187

#2

Updated by Electric Monk over 3 years ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit 3dab25019f363b9dfef49cb3eeb29b0b2023b85b

commit  3dab25019f363b9dfef49cb3eeb29b0b2023b85b
Author: Toomas Soome <tsoome@me.com>
Date:   2017-04-27T01:01:12.000Z

    8010 loader: want mechanism to avoid RA with bcache
    Reviewed by: Dan McDonald <danmcd@omniti.com>
    Reviewed by: Jason King <jason.brian.king@gmail.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF