Project

General

Profile

Bug #8024

mdb_ctf_vread() needn't be so strict about unions

Added by Prakash Surya over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
mdb - modular debugger
Start date:
2017-04-03
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

We can change the restriction in mdb_ctf_vread() to be:

- not all (target) union members must be present (in the mdb type)
- if there are multiple union members (in the mdb type), all members must be exact matches.
- if there is only one union member (in the mdb type), then it need not be an exact match (i.e. it can be a struct with some members, like a normal struct).

By only declaring one member of the union, you are telling mdb_ctf_vread() exactly how to interpret the union.

History

#1

Updated by Electric Monk over 3 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit 53d6c69268ad98d311e74fb98d7514711585c1fa

commit  53d6c69268ad98d311e74fb98d7514711585c1fa
Author: Serapheim Dimitropoulos <serapheim.dimitro@delphix.com>
Date:   2017-04-14T03:46:30.000Z

    8024 mdb_ctf_vread() needn't be so strict about unions
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Pavel Zakharov <pavel.zakharov@delphix.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Dan McDonald <danmcd@omniti.com>

Also available in: Atom PDF