Project

General

Profile

Actions

Bug #8054

closed

git-pbchk error is broken when git is not installed

Added by Dillon Amburgey about 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Low
Category:
tools - gate/build tools
Start date:
2017-04-11
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

~/smartos-live/projects/illumos]# git-pbchk
Traceback (most recent call last):
File "/root/smartos-live/projects/illumos/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/git-pbchk", line 389, in <module>
main(os.path.basename(sys.argv[0]), sys.argv[1:])
File "/root/smartos-live/projects/illumos/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/git-pbchk", line 376, in main
parent_branch = git_parent_branch(git_branch())
File "/root/smartos-live/projects/illumos/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/git-pbchk", line 102, in git_branch
p = git('branch')
File "/root/smartos-live/projects/illumos/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/git-pbchk", line 76, in git
raise GitError("could not execute %s: %s\n" (command, e))
TypeError: 'str' object is not callable

Actions #1

Updated by Electric Monk about 5 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 709afb1d71ef74fa30368e4c94ddec10eeaf890a

commit  709afb1d71ef74fa30368e4c94ddec10eeaf890a
Author: Dillon Amburgey <dillona@dillona.com>
Date:   2017-04-15T04:32:40.000Z

    8054 git-pbchk error is broken when git is not installed
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Dan McDonald <danmcd@omniti.com>

Actions

Also available in: Atom PDF