Project

General

Profile

Bug #8064

need a static DTrace probe in VN_HOLD

Added by Prakash Surya over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
kernel
Start date:
2017-04-13
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

It's currently nearly impossible to trace what process places a hold on
a vnode, as the only ways holds are place is via the `VN_HOLD()` and
`VN_HOLD_CALLER()` macros, which inline the bumping of `v_count`. Adding
static DTrace probes to these macros would enable tracing of where
specific vnode references come from.

For completeness and symmetry, a similar static probe should be added to
`vn_rele()` and `vn_rele_dnlc()`.

History

#1

Updated by Electric Monk over 2 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit ade42b557a6e29c3d17a61b1535d99af10e379be

commit  ade42b557a6e29c3d17a61b1535d99af10e379be
Author: Sebastien Roy <seb@delphix.com>
Date:   2017-05-16T09:07:25.000Z

    8064 need a static DTrace probe in VN_HOLD
    Reviewed by: Pavel Zakharov <pavel.zakharov@delphix.com>
    Reviewed by: Prakash Surya <prakash.surya@delphix.com>
    Reviewed by: Prashanth Sreenivasa <pks@delphix.com>
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

#2

Updated by Electric Monk over 2 years ago

git commit 7da74b7620d65183bc0949a426dc2cad658f19c3

commit  7da74b7620d65183bc0949a426dc2cad658f19c3
Author: Prakash Surya <prakash.surya@delphix.com>
Date:   2017-05-16T22:25:18.000Z

    8064 need a static DTrace probe in VN_HOLD (incorporate review feedback)
    Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF