Project

General

Profile

Bug #8066

loader: zfs reader vdev_probe should check for minimum device size

Added by Toomas Soome almost 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
2017-04-13
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

The smallest device in the pool we can have is 64MB, since we are trying to walk all four labels to find the most up to date uberblock, this limit will also give us good method to check if we even should attempt to probe.

Enforcing the check also will make sure we are not getting wrapped while calculating the label offset.

Also, after label check, we should verify if we actually got any UB or not.
https://reviews.freebsd.org/D10381

History

#1

Updated by Toomas Soome almost 3 years ago

  • Subject changed from loader: zfs reader vdev_probe should check for minimum pool size to loader: zfs reader vdev_probe should check for minimum device size
#2

Updated by Toomas Soome almost 3 years ago

  • Description updated (diff)
#3

Updated by Electric Monk over 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 6617bbf6c820fca35b3a835635d0c5f4641cfa23

commit  6617bbf6c820fca35b3a835635d0c5f4641cfa23
Author: Toomas Soome <tsoome@me.com>
Date:   2017-04-24T15:05:22.000Z

    8066 loader: zfs reader vdev_probe should check for minimum device size
    Reviewed by: Yuri Pankov <yuri.pankov@gmail.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF