Project

General

Profile

Actions
Copy link

Bug #8081

closed

Compiler warnings in zdb

Added by Alan Somers about 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Alan Somers
Category:
zfs - Zettabyte File System
Start date:
2017-04-17
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:
External Bug:

Description

zdb(8) is full of minor problems that generate compiler warnings. On FreeBSD, which uses -WError, the only way to build it is to disable all compiler warnings. This makes it much harder to detect newly introduced bugs. We should cleanup all the warnings.

Actions
Copy link
 #1

Updated by Igor Kozhukhov about 6 years ago

i can try upstream changes what i'm using with DilOS builds - zdb updates have been tested a long time and ready for upstream.

Actions
Copy link
 #2

Updated by Alan Somers about 6 years ago

Igor I've got a patch ready to go based on FreeBSD's build system. I just need to finish testing it on Illumos.

Actions
Copy link
 #3

Updated by Electric Monk over 5 years ago

  • Status changed from New to Closed
  • % Done changed from 50 to 100

git commit 3f7978d02b206a6ebc5652c91aa9f42da6fbe00c

commit  3f7978d02b206a6ebc5652c91aa9f42da6fbe00c
Author: Alan Somers <asomers@gmail.com>
Date:   2017-09-25T19:51:47.000Z

    8081 Compiler warnings in zdb
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Prakash Surya <prakash.surya@delphix.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions
Copy link

Also available in: Atom PDF