Project

General

Profile

Feature #8092

loader.efi: set console mode early in efi_main()

Added by Toomas Soome over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
2017-04-22
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Set console mode in efi_main() and set terminal dimensions there, not in main().

The current code does set fixed terminal size, assuming it is true size; however at least we should query the terminal dimensions. Now there are usually more modes available, making better use possible for the display space. In my opinion it is good idea to try to find "best" dimensions, because some loader commands can produce more information and this way we get better overall user experience.

The terminal dimensions are used for built in pager and command line handling.

Since the loader main() itself is quite loaded by other activities, the efi_main() felt a bit better place for initial screen setup.

#1

Updated by Toomas Soome over 3 years ago

  • Description updated (diff)
#2

Updated by Electric Monk over 3 years ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit 46f02cd8618751466de9f5d6cc8ab2af5cc76ff3

commit  46f02cd8618751466de9f5d6cc8ab2af5cc76ff3
Author: Toomas Soome <tsoome@me.com>
Date:   2017-08-17T13:52:54.000Z

    8092 loader.efi: set console mode early in efi_main()
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF