loader.efi: set console mode early in efi_main()
Set console mode in efi_main() and set terminal dimensions there, not in main().
The current code does set fixed terminal size, assuming it is true size; however at least we should query the terminal dimensions. Now there are usually more modes available, making better use possible for the display space. In my opinion it is good idea to try to find "best" dimensions, because some loader commands can produce more information and this way we get better overall user experience.
The terminal dimensions are used for built in pager and command line handling.
Since the loader main() itself is quite loaded by other activities, the efi_main() felt a bit better place for initial screen setup.
Updated by Electric Monk over 2 years ago
- Status changed from New to Closed
- % Done changed from 90 to 100
commit 46f02cd8618751466de9f5d6cc8ab2af5cc76ff3 Author: Toomas Soome <firstname.lastname@example.org> Date: 2017-08-17T13:52:54.000Z 8092 loader.efi: set console mode early in efi_main() Reviewed by: Robert Mustacchi <email@example.com> Reviewed by: Hans Rosenfeld <firstname.lastname@example.org> Approved by: Dan McDonald <email@example.com>