Project

General

Profile

Actions

Feature #8099

closed

loader: do not build complex commandline for mb2 kernel

Added by Toomas Soome about 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
2017-04-23
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

With boot loader environment being passed to kernel, we do not need to build complex kernel command line for MB2 kernel, instead all automatic properties should be passed in environment and only manually set properties should be set on kernel command line.

so this will set kernel command line:

     ok boot -B console=ttya

but

     ok boot

will keep variables in environment. However, there is one notable exception - if the user did not specify console like above, but there is os_console set in environment, we will pass the "-B console=$os_console" for kernel command line. This exception is because of the nature of os_console variable itself - it was created to distinguish loader console from kernel console.

For multiboot 1 kernels, there are no changes - all properties are set on kernel command line.

Actions #1

Updated by Electric Monk about 6 years ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit ade2ca5bfc7cc2c053e1ffcd03f14b027d63631d

commit  ade2ca5bfc7cc2c053e1ffcd03f14b027d63631d
Author: Toomas Soome <tsoome@me.com>
Date:   2017-05-25T13:58:18.000Z

    8099 loader: do not build complex commandline for mb2 kernel
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Yuri Pankov <yuri.pankov@gmail.com>
    Reviewed by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions

Also available in: Atom PDF