Project

General

Profile

Bug #8108

zdb -l fails to read labels 2 and 3

Added by Yuri Pankov over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Yuri Pankov
Category:
zfs - Zettabyte File System
Start date:
2017-04-25
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

zdb -l fails to read the labels at the end of device:

# zdb -l c1t0d0
------------------------------------
LABEL 0
------------------------------------
    version: 5000
    name: 'rpool'
    state: 0
    txg: 1713820
    pool_guid: 9587152346247280835
    hostid: 492916563
    hostname: ''
    top_guid: 11750409741954155049
    guid: 11750409741954155049
    vdev_children: 1
    vdev_tree:
        type: 'disk'
        id: 0
        guid: 11750409741954155049
        path: '/dev/dsk/c1t0d0s0'
        devid: 'id1,sd@SATA_____OCZ-AGILITY4____OCZ-DC1N3LO88DR4N88H/a'
        phys_path: '/pci@0,0/pci1002,4391@11/disk@0,0:a'
        whole_disk: 1
        metaslab_array: 37
        metaslab_shift: 29
        ashift: 9
        asize: 64009797632
        is_log: 0
        create_txg: 4
    features_for_read:
        com.delphix:hole_birth
        com.delphix:embedded_data
------------------------------------
LABEL 1
------------------------------------
    version: 5000
    name: 'rpool'
    state: 0
    txg: 1713820
    pool_guid: 9587152346247280835
    hostid: 492916563
    hostname: ''
    top_guid: 11750409741954155049
    guid: 11750409741954155049
    vdev_children: 1
    vdev_tree:
        type: 'disk'
        id: 0
        guid: 11750409741954155049
        path: '/dev/dsk/c1t0d0s0'
        devid: 'id1,sd@SATA_____OCZ-AGILITY4____OCZ-DC1N3LO88DR4N88H/a'
        phys_path: '/pci@0,0/pci1002,4391@11/disk@0,0:a'
        whole_disk: 1
        metaslab_array: 37
        metaslab_shift: 29
        ashift: 9
        asize: 64009797632
        is_log: 0
        create_txg: 4
    features_for_read:
        com.delphix:hole_birth
        com.delphix:embedded_data
------------------------------------
LABEL 2
------------------------------------
failed to read label 2
------------------------------------
LABEL 3
------------------------------------
failed to read label 3

the regression was introduced in #6866.

Related issues

Related to illumos gate - Bug #6866: zdb -l should return non-zero if it fails to find any labelClosed2016-04-08

Actions
Related to illumos gate - Bug #8352: stat(2) man page needs to describe difference between stat() and fstat() when working on character special filesNew2017-06-07

Actions
Has duplicate illumos gate - Bug #8233: zdb fails to read label 2 and label 3 after miscalculating addresses of labelsClosed2017-05-15

Actions
Has duplicate illumos gate - Bug #8253: zdb -l doesn't show L2, L3 labelsClosed2017-05-19

Actions

History

#1

Updated by Marcel Telka over 3 years ago

  • Related to Bug #6866: zdb -l should return non-zero if it fails to find any label added
#2

Updated by Yuri Pankov over 3 years ago

  • Has duplicate Bug #8233: zdb fails to read label 2 and label 3 after miscalculating addresses of labels added
#3

Updated by Yuri Pankov over 3 years ago

  • Has duplicate Bug #8253: zdb -l doesn't show L2, L3 labels added
#4

Updated by Yuri Pankov over 3 years ago

  • Related to Bug #8352: stat(2) man page needs to describe difference between stat() and fstat() when working on character special files added
#5

Updated by Electric Monk over 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 50 to 100

git commit 22c8b9583d07895c16549075a53668d7bc988cf3

commit  22c8b9583d07895c16549075a53668d7bc988cf3
Author: Yuri Pankov <yuri.pankov@nexenta.com>
Date:   2017-06-08T01:57:55.000Z

    8108 zdb -l fails to read labels 2 and 3
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF