Project

General

Profile

Actions
Copy link

Bug #8117

closed

loader.efi: ResetSystem does not use data with EFI_SUCCESS

Added by Toomas Soome about 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
bootloader
Start date:
2017-04-27
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

The current reboot command in efi/loader/main.c is using the following call:

RS->ResetSystem(EfiResetCold, EFI_SUCCESS, 23, (CHAR16 *)msg);

However, UEFI spec 2.6, page 265 does state:

"ResetData is only valid if ResetStatus is something other than EFI_SUCCESS unless the ResetType is EfiResetPlatformSpecific where a minimum amount of ResetData is always required."

Therefore we should use DataSize 0 and ResetData NULL - those are two last arguments for the call.

Actions
Copy link
 #1

Updated by Electric Monk about 6 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 48d8443e35c27b5e39226cd33f279567424ad20a

commit  48d8443e35c27b5e39226cd33f279567424ad20a
Author: Toomas Soome <tsoome@me.com>
Date:   2017-05-01T13:48:58.000Z

    8117 loader.efi: ResetSystem does not use data with EFI_SUCCESS
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Yuri Pankov <yuri.pankov@gmail.com>
    Approved by: Dan McDonald <danmcd@omniti.com>

Actions
Copy link

Also available in: Atom PDF