loader.efi: ResetSystem does not use data with EFI_SUCCESS
The current reboot command in efi/loader/main.c is using the following call:
RS->ResetSystem(EfiResetCold, EFI_SUCCESS, 23, (CHAR16 *)msg);
However, UEFI spec 2.6, page 265 does state:
"ResetData is only valid if ResetStatus is something other than EFI_SUCCESS unless the ResetType is EfiResetPlatformSpecific where a minimum amount of ResetData is always required."
Therefore we should use DataSize 0 and ResetData NULL - those are two last arguments for the call.
Updated by Electric Monk over 3 years ago
- Status changed from In Progress to Closed
- % Done changed from 90 to 100
commit 48d8443e35c27b5e39226cd33f279567424ad20a Author: Toomas Soome <email@example.com> Date: 2017-05-01T13:48:58.000Z 8117 loader.efi: ResetSystem does not use data with EFI_SUCCESS Reviewed by: Robert Mustacchi <firstname.lastname@example.org> Reviewed by: Yuri Pankov <email@example.com> Approved by: Dan McDonald <firstname.lastname@example.org>