kmem_move tunables must not be declared static
The kmem_move_* tunables (e.g. kmem_move_noreap) are declared "static".
Because they are never set in the code, the compiler can consider them
constants and optimize them away - removing the code that checks them.
They must not be declared "static" to be used as tunables.
Updated by Electric Monk almost 6 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100
git commit 929d5b43a5225be8ab64d840e6a10803fb6acd0b
commit 929d5b43a5225be8ab64d840e6a10803fb6acd0b Author: Matthew Ahrens <firstname.lastname@example.org> Date: 2017-05-16T22:41:15.000Z 8125 kmem_move tunables must not be declared static Reviewed by: Serapheim Dimitropoulos <email@example.com> Reviewed by: Dan Kimmel <firstname.lastname@example.org> Reviewed by: Prashanth Sreenivasa <email@example.com> Reviewed by: Toomas Soome <firstname.lastname@example.org> Reviewed by: Igor Kozhukhov <email@example.com> Reviewed by: Robert Mustacchi <firstname.lastname@example.org> Approved by: Robert Mustacchi <email@example.com>