Project

General

Profile

Actions

Feature #8127

closed

Feature #8093: loader.efi: cleanup loader main and implement comconsole

loader: add asprintf for libstand

Added by Toomas Soome about 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
2017-04-29
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

The loader libstand is missing asprintf, so lets add it, as it would simplify our life. The implementation is actually quite simple - we let kvprintf() to count the size of the resulting string, we allocate the memory and then fill it.

As the current kvprintf does assume non-NULL buffer, the small update is needed there to make sure we wont dereference the NULL pointer.

Actions #1

Updated by Toomas Soome about 6 years ago

  • Parent task set to #8093
Actions #2

Updated by Electric Monk about 6 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 6ea3a31b44e53b311373bfe0ae8414d122edca27

commit  6ea3a31b44e53b311373bfe0ae8414d122edca27
Author: Toomas Soome <tsoome@me.com>
Date:   2017-05-02T20:30:49.000Z

    8127 loader: add asprintf for libstand
    Reviewed by: Hans Rosenfeld <hans.rosenfeld@joyent.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Dan McDonald <danmcd@omniti.com>

Actions

Also available in: Atom PDF