Project

General

Profile

Bug #8137

sun_fc: NULL pointer is used in wrong context

Added by Toomas Soome over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
lib - userland libraries
Start date:
2017-05-01
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Another issue identified by the 8017 Comply with POSIX.1-2008 and C++11 for the definition of NULL.

../common/TgtFCHBAPort.cc:436:23: error: invalid operands of types 'uint64_t {aka long long unsigned int}' and 'std::nullptr_t' to binary 'operator=='
if (fctio.fctio_obuf == NULL) {

../common/TgtFCHBAPort.cc:444:23: error: invalid operands of types 'uint64_t {aka long long unsigned int}' and 'std::nullptr_t' to binary 'operator!='
if (fctio.fctio_obuf != NULL) {

History

#1

Updated by Electric Monk over 3 years ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit a160fd9a3a7d4d2a7b2979af5e53de5d0ad961aa

commit  a160fd9a3a7d4d2a7b2979af5e53de5d0ad961aa
Author: Toomas Soome <tsoome@me.com>
Date:   2017-05-04T15:40:01.000Z

    8137 sun_fc: NULL pointer is used in wrong context
    Reviewed by: Yuri Pankov <yuri.pankov@gmail.com>
    Reviewed by: Marcel Telka <marcel@telka.sk>
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF