Project

General

Profile

Actions
Copy link

Bug #8155

closed

simplify dmu_write_policy handling of pre-compressed buffers

Added by Serapheim Dimitropoulos about 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Serapheim Dimitropoulos
Category:
zfs - Zettabyte File System
Start date:
2017-05-04
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
External Bug:

Description

When writing pre-compressed buffers, arc_write() requires that the compression algorithm used to compress the buffer matches the compression algorithm requested by the zio_prop_t,
which is set by dmu_write_policy(). This makes dmu_write_policy() and its callers a bit more complicated.

We can simplify this by making arc_write() trust the caller to supply the type of pre-compressed buffer that it wants to write, and override the compression setting in the zio_prop_t.

Actions
Copy link
 #1

Updated by Electric Monk about 6 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit adaec86ad212d9fd756bee322934fa54d1258605

commit  adaec86ad212d9fd756bee322934fa54d1258605
Author: Matthew Ahrens <mahrens@delphix.com>
Date:   2017-06-06T05:02:12.000Z

    8155 simplify dmu_write_policy handling of pre-compressed buffers
    Reviewed by: Dan Kimmel <dan.kimmel@delphix.com>
    Reviewed by: George Wilson <george.wilson@delphix.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Actions
Copy link

Also available in: Atom PDF