Project

General

Profile

Bug #8156

dbuf_evict_notify() does not need dbuf_evict_lock

Added by Serapheim Dimitropoulos over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Serapheim Dimitropoulos
Category:
zfs - Zettabyte File System
Start date:
2017-05-04
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

dbuf_evict_notify() holds the dbuf_evict_lock while checking if it should do the eviction itself
(because the evict thread is not able to keep up). This can result in massive lock contention.
It isn't necessary to hold the lock, because if we make the wrong choice occasionally, nothing
bad will happen.

History

#1

Updated by Electric Monk over 2 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit dbfd9f930004c390a2ce2cf850c71b4f880eef9c

commit  dbfd9f930004c390a2ce2cf850c71b4f880eef9c
Author: Matthew Ahrens <mahrens@delphix.com>
Date:   2017-06-08T01:56:23.000Z

    8156 dbuf_evict_notify() does not need dbuf_evict_lock
    Reviewed by: Dan Kimmel <dan.kimmel@delphix.com>
    Reviewed by: Paul Dagnelie <pcd@delphix.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF