Project

General

Profile

Bug #8185

telnet: misleading-indentation

Added by Toomas Soome about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
2017-05-09
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Building with gcc 6:

commands.c: In function 'status':
commands.c:2444:4: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
    if (my_want_state_is_will(TELOPT_LFLOW))
    ^~
commands.c:2448:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
     encrypt_display();
     ^~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk about 3 years ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 23a2029ddd633754be1176a91553883aa03b6199

commit  23a2029ddd633754be1176a91553883aa03b6199
Author: Toomas Soome <tsoome@me.com>
Date:   2017-05-11T16:16:09.000Z

    8185 telnet: misleading-indentation
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Reviewed by: Aurélien Larcher <aurelien.larcher@gmail.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF