Project

General

Profile

Actions

Bug #8194

closed

kmfcfg: case value not in enumerated type

Added by Toomas Soome over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
2017-05-10
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

Build with gcc 6:

kmfcfg.c:246:3: error: case value '8' not in enumerated type 'KMF_RETURN {aka enum <anonymous>}' [-Werror=switch]
   case KC_ERR_MEMORY:
   ^~~~
kmfcfg.c:249:3: error: case value '9' not in enumerated type 'KMF_RETURN {aka enum <anonymous>}' [-Werror=switch]
   case KC_ERR_ACCESS:
   ^~~~
kmfcfg.c:251:3: error: case value '10' not in enumerated type 'KMF_RETURN {aka enum <anonymous>}' [-Werror=switch]
   case KC_ERR_INSTALL:
   ^~~~
cc1: all warnings being treated as errors

This one is actually more complicated one, as some of the referenced case values are conflicting with values from KMF_RETURN enum. But since the callback is defined to return the int, we will have shortcut there.

Actions #1

Updated by Electric Monk over 6 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit d0d16abc1e2ce70cfd8468614a702b20e1fc7e78

commit  d0d16abc1e2ce70cfd8468614a702b20e1fc7e78
Author: Toomas Soome <tsoome@me.com>
Date:   2017-05-28T02:26:00.000Z

    8194 kmfcfg: case value not in enumerated type
    Reviewed by: Marcel Telka <marcel@telka.sk>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Actions

Also available in: Atom PDF