Project

General

Profile

Actions

Bug #8216

closed

libsldap: misleading-indentation

Added by Toomas Soome about 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
2017-05-13
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

Building with gcc 6:

../common/ns_config.c: In function 'destroy_config':
../common/ns_config.c:838:3: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
   if (ptr->domainName != NULL)
   ^~
../common/ns_config.c:840:4: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
    ptr->domainName = NULL;
    ^~~
cc1: all warnings being treated as errors

Actions #1

Updated by Toomas Soome about 6 years ago

  • Assignee set to Toomas Soome
Actions #2

Updated by Electric Monk about 6 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit a4abf23064b836d7281fdcefd5770736a850349b

commit  a4abf23064b836d7281fdcefd5770736a850349b
Author: Toomas Soome <tsoome@me.com>
Date:   2017-05-14T17:28:58.000Z

    8216 libsldap: misleading-indentation
    Reviewed by: Yuri Pankov <yuri.pankov@gmail.com>
    Reviewed by: Aurélien Larcher <aurelien.larcher@gmail.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Actions

Also available in: Atom PDF