Project

General

Profile

Actions
Copy link

Bug #8217

closed

libldap5: misleading-indentation

Added by Toomas Soome about 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
lib - userland libraries
Start date:
2017-05-13
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

Building with gcc 6:

../sources/ldap/common/sort.c: In function 'ldap_sort_strcasecmp':
../sources/ldap/common/sort.c:159:5: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
     if (NULL == a || NULL == b)
     ^~
../sources/ldap/common/sort.c:161:2: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
  return( strcasecmp( (char *)*a, (char *)*b ) );
  ^~~~~~
cc1: all warnings being treated as errors

Actions
Copy link
 #1

Updated by Electric Monk about 6 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 1307500afcf172c9769fe6fe42f9a5790c1dbe2c

commit  1307500afcf172c9769fe6fe42f9a5790c1dbe2c
Author: Toomas Soome <tsoome@me.com>
Date:   2017-05-13T21:41:32.000Z

    8217 libldap5: misleading-indentation
    Reviewed by: Yuri Pankov <yuri.pankov@gmail.com>
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Actions
Copy link

Also available in: Atom PDF