Project

General

Profile

Actions

Bug #8218

closed

libshare: misleading-indentation

Added by Toomas Soome about 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
2017-05-13
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

Building with gcc 6:

../common/libsharecore.c: In function 'adddfsentry':
../common/libsharecore.c:437:4: error: this 'for' clause does not guard... [-Werror=misleading-indentation]
    for (tmp = list; tmp->next != NULL; tmp = tmp->next)
    ^~~
../common/libsharecore.c:439:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'for'
     tmp->next = item;
     ^~~
cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk about 6 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 41e1be47764ad3e5c5c950b7e2c46a7c4f7ecfd4

commit  41e1be47764ad3e5c5c950b7e2c46a7c4f7ecfd4
Author: Toomas Soome <tsoome@me.com>
Date:   2017-05-13T22:58:00.000Z

    8218 libshare: misleading-indentation
    Reviewed by: Yuri Pankov <yuri.pankov@gmail.com>
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Actions

Also available in: Atom PDF