Project

General

Profile

Actions
Copy link

Bug #8219

closed

mech_krb5: misleading-indentation

Added by Toomas Soome almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
lib - userland libraries
Start date:
2017-05-13
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

Building with gcc 6:

../krb5/os/sendto_kdc.c:1419:5: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
     if (localaddr != 0 && localaddrlen != 0 && *localaddrlen > 0)
     ^~
../krb5/os/sendto_kdc.c:1422:2: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
  if (remoteaddr != 0 && remoteaddrlen != 0 && *remoteaddrlen > 0)
  ^~
cc1: all warnings being treated as errors

And similar for lib/gss_mechs/mech_krb5/krb5/krb/sendauth.c krb5_sendauth().

Actions
Copy link
 #1

Updated by Toomas Soome almost 6 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Electric Monk almost 6 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 49bf4c2bcfc59b4113c3b5ac2986baee668a1319

commit  49bf4c2bcfc59b4113c3b5ac2986baee668a1319
Author: Toomas Soome <tsoome@me.com>
Date:   2017-05-14T18:23:22.000Z

    8219 mech_krb5: misleading-indentation
    Reviewed by: Yuri Pankov <yuri.pankov@gmail.com>
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Reviewed by: Richard Lowe <richlowe@richlowe.net>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Actions
Copy link

Also available in: Atom PDF