Project

General

Profile

Actions
Copy link

Bug #8221

closed

libndmp: misleading-indentation

Added by Toomas Soome almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
lib - userland libraries
Start date:
2017-05-13
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

Building with gcc 6:

../common/libndmp_prop.c: In function 'ndmp_smf_create_service_pgroup':
../common/libndmp_prop.c:318:3: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
   if ((handle->scf_pg =
   ^~
../common/libndmp_prop.c:321:4: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
    return (-1);
    ^~~~~~
cc1: all warnings being treated as errors

Actions
Copy link
 #1

Updated by Electric Monk almost 6 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit faf269d301b574ab95145509e30b86f2caad6578

commit  faf269d301b574ab95145509e30b86f2caad6578
Author: Toomas Soome <tsoome@me.com>
Date:   2017-05-15T17:15:31.000Z

    8221 libndmp: misleading-indentation
    Reviewed by: Yuri Pankov <yuri.pankov@gmail.com>
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Reviewed by: Dan Fields <danfields@fastmail.us>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Actions
Copy link

Also available in: Atom PDF