Project

General

Profile

Actions
Copy link

Bug #8223

closed

libshell: misleading-indentation

Added by Toomas Soome about 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
lib - userland libraries
Start date:
2017-05-13
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

Building with gcc 6:

../common/sh/nvdisc.c: In function 'nv_clone':
../common/sh/nvdisc.c:916:2: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
  if(mp->nvflag == flag)
  ^~
../common/sh/nvdisc.c:918:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
   if(nv_isattr(np,NV_EXPORT))
   ^~
cc1: all warnings being treated as errors

Actions
Copy link
 #1

Updated by Electric Monk almost 6 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 0d56f5df8a4bc5dd756cf0ea58ab3e0519c76032

commit  0d56f5df8a4bc5dd756cf0ea58ab3e0519c76032
Author: Toomas Soome <tsoome@me.com>
Date:   2017-06-19T17:08:27.000Z

    8223 libshell: misleading-indentation
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Gordon Ross <gordon.w.ross@gmail.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions
Copy link

Also available in: Atom PDF