Project

General

Profile

Actions
Copy link

Bug #8230

closed

e1000api: misleading-indentation

Added by Toomas Soome about 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
driver - device drivers
Start date:
2017-05-15
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

Building with gcc 6:

../../common/io/e1000api/e1000_ich8lan.c: In function 'e1000_disable_ulp_lpt_lp':
../../common/io/e1000api/e1000_ich8lan.c:1499:2: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
  if (ret_val)
  ^~
../../common/io/e1000api/e1000_ich8lan.c:1501:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
   phy_reg &= ~(I218_ULP_CONFIG1_IND |
   ^~~~~~~
../../common/io/e1000api/e1000_ich8lan.c: In function 'e1000_check_for_copper_link_ich8lan':
../../common/io/e1000api/e1000_ich8lan.c:1558:2: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
  if (!mac->get_link_status)
  ^~
../../common/io/e1000api/e1000_ich8lan.c:1565:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
   ret_val = e1000_phy_has_link_generic(hw, 1, 0, &link);
   ^~~~~~~
cc1: all warnings being treated as errors

Actions
Copy link
 #1

Updated by Electric Monk about 6 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 30f1f754a88aa357235064d8c7ce78f2f546e0aa

commit  30f1f754a88aa357235064d8c7ce78f2f546e0aa
Author: Toomas Soome <tsoome@me.com>
Date:   2017-05-17T11:17:19.000Z

    8230 e1000api: misleading-indentation
    Reviewed by: Yuri Pankov <yuri.pankov@gmail.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>

Actions
Copy link

Also available in: Atom PDF