Project

General

Profile

Actions
Copy link

Bug #8232

closed

pcmcia: misleading-indentation

Added by Toomas Soome about 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
driver - device drivers
Start date:
2017-05-15
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

Building with gcc 6:

../../common/pcmcia/nexus/pcmcia.c: In function 'pcmcia_intr_disable_isr':
../../common/pcmcia/nexus/pcmcia.c:5428:4: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
    if (intr->handler_id != (uint32_t)(uintptr_t)rdip)
    ^~
../../common/pcmcia/nexus/pcmcia.c:5434:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
     ispecp = (struct intrspec *)&sockp->ls_intrspec;
     ^~~~~~
cc1: all warnings being treated as errors

Actions
Copy link
 #1

Updated by Electric Monk almost 6 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 3f068ebd9d125396d22997224889b677a22523fe

commit  3f068ebd9d125396d22997224889b677a22523fe
Author: Toomas Soome <tsoome@me.com>
Date:   2017-06-12T14:59:01.000Z

    8232 pcmcia: misleading-indentation
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Yuri Pankov <yuripv@gmx.com>
    Approved by: Dan McDonald <danmcd@omniti.com>

Actions
Copy link

Also available in: Atom PDF