Project

General

Profile

Bug #8236

fwflash sd plugin shouldn't hardcode maximum image size

Added by Robert Mustacchi over 2 years ago. Updated 11 months ago.

Status:
Closed
Priority:
Normal
Category:
cmd - userland programs
Start date:
2017-05-15
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

The sd image verifier for fwflash hardcodes the maximum image size to be a simple 1 MiB. However, the actual size that's allowed and supported by the device may be much larger. Instead, we should ask the device for what the maximum supported size is and use this to determine the upper bound.

History

#1

Updated by Electric Monk 11 months ago

  • Status changed from New to Closed

git commit 0b4d657578b8f707371421ebae5b3837023b4144

commit  0b4d657578b8f707371421ebae5b3837023b4144
Author: Robert Mustacchi <rm@joyent.com>
Date:   2019-01-16T00:48:38.000Z

    8235 fwflash for sd needs to handle partial writes
    8236 fwflash sd plugin shouldn't hardcode maximum image size
    8237 libscsi improperly translates request sense and isolate options to uscsi
    Reviewed by: Joshua M. Clulow <jmc@joyent.com>
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF