Project

General

Profile

Actions
Copy link

Bug #8237

closed

libscsi improperly translates request sense and isolate options to uscsi

Added by Robert Mustacchi about 6 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Robert Mustacchi
Category:
lib - userland libraries
Start date:
2017-05-15
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

The uscsi engine of libscsi translates various libscsi flags into uscsi flags. Importantly, it translates the following LIBSCSI_AF_ISOLATE to USCSI_ISOLATE and LIBSCSI_AF_RQSENSE to USCSI_RQENABLE.

Unfortunately the logic in translating the flags in xlate_flags() in lib/scsi/plugins/scsi/engines/uscsi/uscsi.c does not or in those two flags but assigns them. However, they're perfectly valid to be combined and this seems like a logic bug here.

Actions
Copy link
 #1

Updated by Electric Monk over 4 years ago

  • Status changed from New to Closed

git commit 0b4d657578b8f707371421ebae5b3837023b4144

commit  0b4d657578b8f707371421ebae5b3837023b4144
Author: Robert Mustacchi <rm@joyent.com>
Date:   2019-01-16T00:48:38.000Z

    8235 fwflash for sd needs to handle partial writes
    8236 fwflash sd plugin shouldn't hardcode maximum image size
    8237 libscsi improperly translates request sense and isolate options to uscsi
    Reviewed by: Joshua M. Clulow <jmc@joyent.com>
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions
Copy link

Also available in: Atom PDF