Project

General

Profile

Actions

Bug #8237

closed

libscsi improperly translates request sense and isolate options to uscsi

Added by Robert Mustacchi about 5 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Category:
lib - userland libraries
Start date:
2017-05-15
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

The uscsi engine of libscsi translates various libscsi flags into uscsi flags. Importantly, it translates the following LIBSCSI_AF_ISOLATE to USCSI_ISOLATE and LIBSCSI_AF_RQSENSE to USCSI_RQENABLE.

Unfortunately the logic in translating the flags in xlate_flags() in lib/scsi/plugins/scsi/engines/uscsi/uscsi.c does not or in those two flags but assigns them. However, they're perfectly valid to be combined and this seems like a logic bug here.

Actions

Also available in: Atom PDF