zdb -l doesn't show L2, L3 labels
zdb shows labels L0, L1, but L2, L3 empty.
The bug was introduced by this changes:
The reason is open64 call was moved bellow stat64 one, as result stat64 returns zero in st_size.
Because of 0 size vdev_label_offset call returns invalid value and zdb failed to read labels L2, L3
Moving open64 call above stat64 (as it was before the change) fixes the issue.
Updated by Electric Monk about 3 years ago
- Status changed from New to Closed
commit 22c8b9583d07895c16549075a53668d7bc988cf3 Author: Yuri Pankov <firstname.lastname@example.org> Date: 2017-06-08T01:57:55.000Z 8108 zdb -l fails to read labels 2 and 3 Reviewed by: Matthew Ahrens <email@example.com> Reviewed by: Toomas Soome <firstname.lastname@example.org> Reviewed by: Igor Kozhukhov <email@example.com> Reviewed by: Andrew Stormont <firstname.lastname@example.org> Approved by: Robert Mustacchi <email@example.com>