Project

General

Profile

Actions

Bug #8260

open

mdb: qlc module is using bogus test to verify the read of the read ql_hba structure

Added by Toomas Soome about 5 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
mdb - modular debugger
Start date:
2017-05-21
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

mdb/common/modules/qlc/qlc.c is using the following construct:

        ql_head_t               ql_hba;

        if (mdb_readvar(&ql_hba, "ql_hba") == -1) {
                mdb_warn("failed to read ql_hba structure");
                return (DCMD_ERR);
        }

        if (&ql_hba == NULL) {
                mdb_warn("failed to read ql_hba structure -- is qlc loaded?");
                return (DCMD_ERR);
        }

However, since ql_hba is structure, the &ql_hba can not be NULL and therefore this test is quite meaningless. This construct can be found in few different functions in qlc.c.

No data to display

Actions

Also available in: Atom PDF