dnlc_reverse_lookup() is unsafe at any speed
Doing a reverse "lookup" in the DNLC (in air quotes because it's a scan, not a lookup) is unsafe at any speed – there shouldn't be an interface to do it, and consumers of it should simply assume that dnlc_reverse_lookup() returns nothing. Doing this resolves acute performance issues that we've seen in production in getcwd(), reading LX pmaps and other domains.
Updated by Electric Monk over 2 years ago
- % Done changed from 0 to 100
- Status changed from New to Closed
commit f176a0a4cd61cbd708a7f25dc30d221f4d5902ba Author: Bryan Cantrill <firstname.lastname@example.org> Date: 2017-06-07T20:00:15.000Z 8270 dnlc_reverse_lookup() is unsafe at any speed Reviewed by: Patrick Mooney <email@example.com> Reviewed by: Andy Stormont <firstname.lastname@example.org> Reviewed by: Yuri Pankov <email@example.com> Reviewed by: Toomas Soome <firstname.lastname@example.org> Approved by: Richard Lowe <email@example.com>