Project

General

Profile

Bug #8282

hci1394: self-comparison always evaluates to true

Added by Toomas Soome about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
driver - device drivers
Start date:
2017-05-28
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build error with gcc 6:

../../common/io/1394/adapters/hci1394_ixl_update.c: In function 'hci1394_ixl_update_prep_recv_buf':
../../common/io/1394/adapters/hci1394_ixl_update.c:1139:35: error: self-comparison always evaluates to true [-Werror=tautological-compare]
      (new_xfer_buf_ixlp->mem_bufp == new_xfer_buf_ixlp->mem_bufp)) {
                                   ^~
cc1: all warnings being treated as errors

History

#1

Updated by Toomas Soome about 3 years ago

  • Category changed from kernel to driver - device drivers
#2

Updated by Electric Monk about 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 46776310d043163e2f3f1bfbb86de739e691090a

commit  46776310d043163e2f3f1bfbb86de739e691090a
Author: Toomas Soome <tsoome@me.com>
Date:   2017-06-02T17:48:12.000Z

    8282 hci1394: self-comparison always evaluates to true
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Yuri Pankov <yuripv@gmx.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF